Fix HDF5 dataset #1545
Open
Fix HDF5 dataset #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't provide parameters for superclass __new__ method (object.__new__). 2. Add function calls where required. 3. Fix interaction with iterators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I tried to use .h5 file as data source and it didn't go smooth.
Here are some fixes that allowed me to iterate through a file created using pandas.HDFStore.
__new__method (object.__new__).Seems some time ago HDF5Dataset was based on DenseDesignMatrix but now its just Dataset and this code path breaks.
Not sure how the interaction is designed to be.
One problem was that pytables returns numpy array of lists instead of tuples and this breaks https://github.com/lisa-lab/pylearn2/blob/master/pylearn2/space/__init__.py#L1481 since the array is 1-dimensional.
Second one is iterator calling
np_format_ason tuple of tuples which failsis_numeric_batchcheck.I'm a total novice with pylearn2. Please tell me if this can be implemented in more canonical way.