[da-vinci][dvc] Dropping unassigned partitions #1332
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristyelee
commented
Nov 26, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/StoreBackend.java
Outdated
Show resolved
Hide resolved
kvargha
reviewed
Dec 4, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java
Outdated
Show resolved
Hide resolved
kristyelee
force-pushed
the
kristy_lee/650_davinci
branch
from
2055b04 to
52a557c
Compare
kristyelee
force-pushed
the
kristy_lee/650_davinci
branch
from
b94b49a to
262bbc6
Compare
…iption. Enabled config flag over bootstrap subscription
…iption. Enabled config flag over bootstrap subscription
kvargha
reviewed
Dec 10, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/DaVinciBackend.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/ConfigKeys.java
Outdated
Show resolved
Hide resolved
kristyelee
force-pushed
the
kristy_lee/650_davinci
branch
from
a163e56 to
9dbffc9
Compare
…cally. Integration Test [In Writing]
kristyelee
force-pushed
the
kristy_lee/650_davinci
branch
from
9dbffc9 to
fd9fa02
Compare
…cally. Integration Test [In Writing]
kvargha
reviewed
Dec 13, 2024
...ice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciClientTest.java
Outdated
Show resolved
Hide resolved
…cally. Integration Test [In Writing]
…cally. Integration Test [In Writing]
ZacAttack
reviewed
Dec 16, 2024
clients/da-vinci-client/src/main/java/com/linkedin/davinci/client/AvroGenericDaVinciClient.java
Show resolved
Hide resolved
ZacAttack
reviewed
Dec 16, 2024
| StoreBackend storeBackend = getStoreOrThrow(storeName); | ||
| storeBackend.subscribe(ComplementSet.newSet(partitions), Optional.of(version)); | ||
| }); | ||
| if (configLoader.getCombinedProperties().getBoolean(DA_VINCI_SUBSCRIBE_ON_DISK_PARTITIONS_AUTOMATICALLY, true)) { |
There was a problem hiding this comment.
This looks like a good start, but do we need to do clean up? @sixpluszero @kvargha ?
There was a problem hiding this comment.
Maybe we add a method to the interface which allows users to clean up unsubscribed state?
ZacAttack
reviewed
Dec 16, 2024
...ice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciClientTest.java
Outdated
Show resolved
Hide resolved
ZacAttack
reviewed
Dec 16, 2024
...ice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciClientTest.java
Show resolved
Hide resolved
…cally. Integration Test [In Writing]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
The objective is to remove unassigned partitions.
Applying this issue to Da Vinci Client which has information over partitions in storage.
This PR is an extension of the PR #1196 [https://github.com//pull/1196] that checks which partitions should be kept [in
StorageService] and applies the check inVeniceServer.Resolves #650
How was this PR tested?
A corresponding test will be written.
Does this PR introduce any user-facing changes?