fix disable limit cause unvet

lidofinance · Dec 1, 2023 · d17ecbc · d17ecbc
1 parent 6edac12
commit d17ecbc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/CSModule.sol b/src/CSModule.sol
@@ -694,7 +694,7 @@ contract CSModule is IStakingModule, CSModuleBase {
         ) return;
 
         if (
-            no.isTargetLimitActive != isTargetLimitActive ||
+            (!no.isTargetLimitActive && isTargetLimitActive) ||
             targetLimit < no.targetLimit
         ) {
             _unvetKeys(nodeOperatorId);

diff --git a/test/CSModule.t.sol b/test/CSModule.t.sol
@@ -1133,6 +1133,19 @@ contract CsmUpdateTargetValidatorsLimits is CSMCommon {
         assertEq(no.totalVettedValidators, 1);
     }
 
+    function test_updateTargetValidatorsLimits_NoUnvetKeysWhenLimitDisabled()
+        public
+    {
+        uint256 noId = createNodeOperator(2);
+        csm.updateTargetValidatorsLimits(noId, true, 1);
+
+        csm.vetKeys(noId, 1);
+
+        csm.updateTargetValidatorsLimits(noId, false, 1);
+        NodeOperatorInfo memory no = csm.getNodeOperator(noId);
+        assertEq(no.totalVettedValidators, 1);
+    }
+
     function test_updateTargetValidatorsLimits_RevertWhenNoNodeOperator()
         public
     {