fix(sampledconn): Correctly handle slow bytes and closed conns #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
force-pushed
the
marco/fix-spin
branch
from
07f78ef to
5ee845d
Compare
MarcoPolo
force-pushed
the
marco/fix-spin
branch
from
5ee845d to
ca3d29f
Compare
|
Currently investigating why linux fails here. |
6 tasks
Not worth fiddling with the OS api right now
|
I've removed the OS specific things. The wrapper approach works fine and avoids a lot of complexity. |
sukunrt
approved these changes
Dec 6, 2024
| @@ -63,7 +64,7 @@ func TestSampledConn(t *testing.T) { | |||
| assert.Equal(t, "hello", string(buf)) | |||
| } else { | |||
| // Wrap the client connection in SampledConn | |||
| sample, sampledConn, err := newFallbackSampledConn(clientConn.(ManetTCPConnInterface)) | |||
There was a problem hiding this comment.
should we rename fallbackPeekingConn to sampledConn?
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Dec 10, 2024
testing fix from libp2p/go-libp2p#3080
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.