feat: increase the max record age to 48h (PUT_VALUE, RFM17) (#794)

* increase the max record age for the PUT_VALUE method based on RFM17 * refactor: reuse providers.ProvideValidity Co-authored-by: Marcin Rataj <lidel@lidel.org>
libp2p · Dec 11, 2022 · c8b17c2 · c8b17c2
1 parent 5999afb
commit c8b17c2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/internal/config/config.go b/internal/config/config.go
@@ -114,7 +114,7 @@ var Defaults = func(o *Config) error {
 	o.RoutingTable.RefreshInterval = 10 * time.Minute
 	o.RoutingTable.AutoRefresh = true
 	o.RoutingTable.PeerFilter = EmptyRTFilter
-	o.MaxRecordAge = time.Hour * 36
+	o.MaxRecordAge = providers.ProvideValidity
 
 	o.BucketSize = defaultBucketSize
 	o.Concurrency = 10

diff --git a/providers/providers_manager.go b/providers/providers_manager.go
@@ -30,7 +30,8 @@ const ProvidersKeyPrefix = "/providers/"
 // the records we return will require an extra lookup.
 const ProviderAddrTTL = time.Minute * 30
 
-// ProvideValidity is the default time that a provider record should last
+// ProvideValidity is the default time that a Provider Record should last on DHT
+// This value is also known as Provider Record Expiration Interval.
 var ProvideValidity = time.Hour * 48
 var defaultCleanupInterval = time.Hour
 var lruCacheSize = 256