Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of timeouts when federates connect to RTI/each other #407

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Improve handling of timeouts when federates connect to RTI/each other #407

merged 2 commits into from
Apr 12, 2024

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Apr 4, 2024

This PR makes a minor improvement on the timeouts when federates connect to the RTI and each other.

  1. Use a timeout duration rather than a retry count
  2. Increase the value from 2.5sec for fed->fed and 50sec fed->RTI to 1minute for both.
  3. Add the convenience macro CHECK_TIMEOUT to simplify

@erlingrj erlingrj added enhancement Enhancement of existing feature federated labels Apr 4, 2024
edwardalee
edwardalee approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The MacOS failures do not look related to me. Looks like lfc is deadlocking.

erlingrj added 2 commits April 11, 2024 22:27
@erlingrj @lhstrh
Improve federate connect timout.
fac0e50 
- Use a timeout rather than a retry count
- Add a CHECK_TIMEOUT macro for checking for timeouts
@erlingrj @lhstrh
Fix some typos
7ffb1fe
@lhstrh lhstrh force-pushed the improve-fed-retry branch from a127d4f to 7ffb1fe Compare April 12, 2024 05:27
@lhstrh lhstrh enabled auto-merge April 12, 2024 06:37
@lhstrh lhstrh added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit b64a805 Apr 12, 2024
30 checks passed
@erlingrj erlingrj deleted the improve-fed-retry branch May 6, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature federated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlingrj @edwardalee @lhstrh