Update RTI dockerfile to match file layout change #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could harm reproducibility and could increase the size of the RTI image. However, reproducibility is actually not much worse than the status quo which was still copying whole directories. Also, the amount of extra stuff copied is small. In the long run this will keep us from running into further problems as we continue to refactor this repo without testing the dockerized RTI build in CI (I am assuming that it is not worthwhile to add a test for it in CI)
petervdonovan
force-pushed
the
update-rti-dockerfile
branch
from
ee0a6e6 to
8158f7c
Compare
|
Hm, @lhstrh told me that the target parameter: Would trigger lfc to build a docker image, presumably with the Dockerfile, and this is apparently used in CI, I wonder why those tests didn't fail after your refactoring Peter |
OK, filed a PR (lf-lang/lingua-franca#2249) to fix the error handling. |
erlingrj
approved these changes
Mar 28, 2024
lhstrh
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
This looks good but needs to be merged after lf-lang/lingua-franca#2249, which still reports failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could harm reproducibility and could increase the size of the RTI image. However, reproducibility is actually not much worse than the status quo which was still copying whole directories. Also, the amount of extra stuff copied is small. In the long run this will keep us from running into further problems as we continue to refactor this repo without testing the dockerized RTI build in CI (I am assuming that it is not worthwhile to add a test for it in CI)
I have manually verified that this does build locally.