Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

This repository needs a .gitignore #63

Merged
merged 3 commits into from
Jul 31, 2024
Merged

This repository needs a .gitignore #63

merged 3 commits into from
Jul 31, 2024

Conversation

xuyb1999
Copy link
Contributor

  1. When executing make downloadcheck, this command will download mill files to created directory 'out', which makes git status dirty.
  2. When the download process is interrupted, temporary mill.* files will not be cleaned automatically, thus we need to update the make clean rule.

xuyb1999 added 2 commits July 10, 2024 19:22
1. When executing 'make downloadcheck', this command will download
mill files to created directory 'out', which makes git status dirty.
2. When the download process is interrupted, temporary mill.* files
will not be cleaned automatically, thus pollute git status.
Copy link
Owner

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. The .vscode is unrelated to this project though, as it depends on your personal editor preference. (You can add it to your local .git/info/exclude instead.)

.gitignore Outdated Show resolved Hide resolved
Remove .vscode from .gitignore, as it is not related to this project

Co-authored-by: Tobias Roeser <le.petit.fou@web.de>
Copy link
Owner

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lefou lefou merged commit 62bbce8 into lefou:main Jul 31, 2024
2 checks passed
@lefou lefou added this to the 0.4.13 milestone Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants