This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - feat(representation_theory/monoid_algebra_basis): add some API for k[G^n]
#14308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101damnations
added
the
awaiting-review
The author would like community review of the PR
label
May 22, 2022
kim-em
reviewed
May 23, 2022
kim-em
reviewed
May 23, 2022
kim-em
reviewed
May 23, 2022
Closed
101damnations
commented
May 26, 2022
This all looks very elegant -- it's definition-heavy, but I guess the branch linked to above is evidence that the definitions are usable! |
ocfnash
reviewed
Jun 10, 2022
There are no mathematical changes here. An approximate summary of what has been done is: * Adjust module doc string a little * Adjust naming / namespacing * Regroup content to separate linear algebra from category-theoretic constructs * Regroup content to reduce implicit / explicit `variables` switching The naming / namespacing still needs improvement.
eric-wieser
reviewed
Jun 24, 2022
eric-wieser
reviewed
Jun 24, 2022
ocfnash
force-pushed
the
monoid-algebra-basis
branch
from
June 26, 2022 16:45
14f1103
to
75b356d
Compare
eric-wieser
reviewed
Jun 26, 2022
Also: * clean up legacy `to_prod` naming * add missing `to_additive` decorators
@semorrison do you have anything to add? (I think Scott is unfortunately busy with other things right now) |
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Jul 11, 2022
bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
…[G^n]` (#14308) Co-authored-by: Oliver Nash <github@olivernash.org>
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
…[G^n]` (#14308) Co-authored-by: Oliver Nash <github@olivernash.org>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(representation_theory/monoid_algebra_basis): add some API for
[Merged by Bors] - feat(representation_theory/monoid_algebra_basis): add some API for Jul 12, 2022
k[G^n]
k[G^n]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this Zulip thread for discussion. I'm not sure what to call the file...$k[G^{n + 1}]$ is free over $k[G]$ from the fact that $k[G^{n + 1}] \cong k[G] \otimes_k k[G^n].$
See this branch for what will be added to this file in future: a proof