Update smeltery.mdoc

[Talyda]

I don't know how to make this just for the supported versions. Should I just edit the text in teh "hint" section to have the correct information for current versions?
Also no idea how to change the worker skills, cos they aren't on this page? Need to remove the strength bit, cos it doesn't do anything apparently

[Thodor12]

You can leave the new and old content in a version block, like so:

{% version name="1.20" after=true %}
New content
{% /version %}
{% version name="1.19.2" before=true %}
Old content
{% /version %}

Change the versions where applicable

Also, no need to modify the skills, even if it doesn't do anything, do not unset it

[Talyda]

I did another commit, with the versions, did I do that right? Both the commit bit, and the versions bit =D I think that is how I was supposed to change the PR? With the second commit? Seriously github is so confusing to me

Also, the skills section needs to be corrected though, as it currently says "Strength: Increases chance of doubling or tripling ores" and that is just not accurate any more

[Thodor12]

The version blocks always include the version you named itself, so if you were to open 1.18.2 like this, you'd get both pieces of text.
It always has to be "version" after=true and "version - 1" before=true

[Talyda]

ok! Thanks BTW! I swear I was doing this so you DIDN'T have to do as much yourself =P But by the time we drill into my brain the correct way, it probably would have been quicker for you to do it =D

[Thodor12]

Note: Every single MC version is defined in the list of versions. So there is a gap between 1.18.2 and 1.19.2, there is nothing shown for 1.19 and 1.19.1 right now

[Talyda]

I was literally just looking at that and thinking I needed to change it =D

[Thodor12]

For the skills, you have to open the src/content/workers/smelter.yaml. This contains all of the information related to workers, along with their traits.
You can apply overrides for later versions in case something changes like so:

name: Smelter
plural: Smelters
description: The Smelter can turn all of your ores into ingots, higher level Smelteries can utilize more furnaces.
icon: "@assets/images/wiki/workers/smelter/male/default-a.png"
type: gatherer
traits:
  primary:
    name: Athletics
    effect: Faster smelting
  secondary:
    name: Strength
    effect: Increases chance of doubling or tripling ores
primaryBuilding: buildings/smeltery
overrides:
  - version: "1.20"
    traits:
      secondary:
        effect: New description

[Talyda]

Would putting 1.19 in the override section work for 1.19+ or do I need to do the "{% version name="1.19" after=true %}"
and just leave effect blank?

[Thodor12]

The overrides are always increment upwards, so it will take the highest version and look downwards until it finds the most recent override

[Talyda]

ok! So maybe correct now?
If I get the hang of this I might be able to help more =P

[Thodor12]

The secondary skill affects furnace speed nowadays, the higher the skill the faster furnaces will work

[Talyda]

That's the primary skills affect. Do both do it? I thought I remembered reading it didn't do anything any more

[Thodor12]

New primary skill is being able to use more furnaces, up to 10 it seems

[Talyda]

I thought that was set by hut level, should I remove the bit about higher level building uses more furnaces? Oh, or is it like they can use up to 10 based on skill, but still "x" per building level as well? (I assume 2 per level?)

[MotionlessTrain]

Not sure whether it makes sense to explicitly mention 1.16, now that that text is only shown for older versions

[Thodor12]

@MotionlessTrain Unfortunately it's not as easy to set up version ranges, I might modify the version block to be more of an expression

[MotionlessTrain]

I mean, the text explicitly mentions “in 1.16”, which I think can be removed now, as it should apply to all versions in that version block

[Thodor12]

@Talyda There seems to be no limit on furnaces per building level at all. As far as I can tell at least. The furnace module gathers all possible furnaces in the schematic, no limit. And there's a piece of code in the smelter AI that will get the amount of usable furnaces:

    private int getMaxUsableFurnaces()
    {
        final int maxSkillFurnaces = (worker.getCitizenData().getCitizenSkillHandler().getLevel(getModuleForJob().getPrimarySkill()) / 10) + 1;
        return Math.min(maxSkillFurnaces, building.getFirstModuleOccurance(FurnaceUserModule.class).getFurnaces().size());
    }

The sole limit here seems skill (and the amount of furnaces in the schematic), skill is capped at 99, means 1 + (99 / 10 = 9) = 10 at max.

[Talyda]

Not sure whether it makes sense to explicitly mention 1.16, now that that text is only shown for older versions

Oh, I missed that, thanks! I was too worried about getting the version stuff, and copied the old text verbatim

[Talyda]

The sole limit here seems skill (and the amount of furnaces in the schematic)

okey dokey! Will change the skills and no mention of how many per level

[Thodor12]

Also, now that we've discovered this, might want to immediately change up the schematics.mdoc. And change the line

| {% building name="smeltery" /%}      | 1 furnace per level | |

to

| {% building name="smeltery" /%}      | 1 furnace | 2 furnaces per level |

[Talyda]

Ermm, I'm not sure if i messed the formatting on the schematics page? I can't actually see a preview of the page. Actually, is there a way for me to see a preview of it?

[Thodor12]

Ermm, I'm not sure if i messed the formatting on the schematics page? I can't actually see a preview of the page. Actually, is there a way for me to see a preview of it?

Only by running the project locally, it's described in the README how to I think

[MotionlessTrain]

Also, now that we've discovered this, might want to immediately change up the schematics.mdoc. And change the line

| {% building name="smeltery" /%}      | 1 furnace per level | |

to

| {% building name="smeltery" /%}      | 1 furnace | 2 furnaces per level |

I believe it is still recommend to only have 1 per level. Even though they can work with two, I’m not sure whether we should mention that.
That is something to ask Raycoms