fix(cli): set stateBlock to latest block instead of the deploy block #3424
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JackieXu
force-pushed
the
fix/stateBlock
branch
from
c218808 to
8d42545
Compare
holic
reviewed
Jan 7, 2025
| @@ -41,9 +41,12 @@ export async function getWorldDeploy( | |||
| throw new Error("could not find `HelloWorld` or `HelloStore` event"); | |||
| } | |||
|
|
|||
| // Fetch latest block to set the range of blocks for logs retrieval. | |||
| const stateBlock = await getBlock(client, { blockTag: "latest" }); | |||
There was a problem hiding this comment.
maybe move this up to dedupe the two calls above to the latest block?
JackieXu
force-pushed
the
fix/stateBlock
branch
from
8d42545 to
e2659c9
Compare
holic
reviewed
Jan 7, 2025
| @@ -24,9 +24,12 @@ export async function getWorldDeploy( | |||
|
|
|||
| debug("looking up world deploy for", address); | |||
|
|
|||
| // Fetch latest block to set the range of blocks for logs retrieval. | |||
| const stateBlock = await getBlock(client, { blockTag: "latest" }); | |||
There was a problem hiding this comment.
there's one more usage above this too!
JackieXu
force-pushed
the
fix/stateBlock
branch
from
e2659c9 to
a441683
Compare
alvrs
reviewed
Jan 7, 2025
alvrs
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.