Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/pool #1530

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Hotfix/pool #1530

merged 4 commits into from
Jan 13, 2025

Conversation

maddyscientist
Copy link
Member

Minor hotfix PR

  • Expose new interface function flushPoolQuda(QudaMemoryType) to facilitate user control over flushing QUDA's memory pools
  • Remove legacy option QudaMultigridParam::setup_minimize_memory which was broken, and redundant in the era of unified memory
  • Fix BiCGStab and BiCGStab(l) for use as null-space generators

@maddyscientist maddyscientist requested a review from a team as a code owner January 13, 2025 19:16
Copy link
Member

@bjoo bjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice and clean to me - only the question about the strategy to bomb on OpenMP with the NVHPC++ compiler remains and it is not very important. I am happy to approve this.

CMakeLists.txt Show resolved Hide resolved
@weinbe2 weinbe2 merged commit 9765847 into develop Jan 13, 2025
7 checks passed
@weinbe2 weinbe2 deleted the hotfix/pool branch January 13, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants