-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meson option to disable explicit EC keys tests #492
Conversation
Should we make it the other way round and disable the explicit curves by default and enable them only if some configuration option is provided instead? |
Would be better, I think debian is the only one that allows it. |
@Jakuje Not sure how you want to handle the workflow config, I just copied what was already done for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one nit, otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thank you for your contribution!
@Mulling can you please squash the commits and rebase on main? |
3636429
to
4ab95c5
Compare
* Disable explicit EC keys tests by default Signed-off-by: Lucas Mulling <lucas.mulling@suse.com>
Not sure why Coverity Scan is failing. |
Don't worry about it, we'll handle it later, it is just telling that actual code has changed and a scan should be rerun (it is not automatically run for "reasons"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds a meson option to disable explicit EC keys tests.
Checklist
Reviewer's checklist: