Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Create separate self-signed EC key for tlsfuzzer testing #490

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Dec 20, 2024

Description

Follow up from #488, where we found the tlsfuzzer has problems with heterogeneous CA + server keys. This creates separate EC key outside of the main CA chain (EC Peer key used for ECDH generally), which turned out to be easier than I expected. It also simplifies the setup a bit and removes the excluded test cases, that should be working.

Checklist

  • Test suite updated with functionality tests
  • Test suite updated with negative tests

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

simo5
simo5 previously approved these changes Dec 20, 2024
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit, otherwise LGTM

tests/setup.sh Outdated Show resolved Hide resolved
Follow up from latchset#488

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Copy link

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@simo5 simo5 merged commit b6a4d65 into latchset:main Jan 6, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants