Update service.py #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| author = Author(mail=email, is_banned=False) | ||
| db.session.add(author) | ||
|
|
||
| if sendMailAndVerify(email): |
There was a problem hiding this comment.
@pan0303 This checks email validity before adding the author. Why don't you also check email validity before one posts an article? -Hui
|
Thank you for your suggestion! We will elaborate our improvement as soon as possible and the accomplishment will be shown to you on Monday!
…------------------ Original ------------------
From: "Software Project Management";<notifications@github.com>;
Send time: Saturday, Dec 26, 2020 4:28 PM
To: "lanlab-org/OAPS-TreeLib"<OAPS-TreeLib@noreply.github.com>;
Cc: "咚锵同学呀"<1192494431@qq.com>; "Mention"<mention@noreply.github.com>;
Subject: Re: [lanlab-org/OAPS-TreeLib] Update service.py (#44)
@spm2020spring commented on this pull request.
In service.py:
> @@ -436,10 +463,12 @@ def post_article(): if request.method == 'POST': email = request.form['email'] # means that author isn't in database now - if not Author.query.filter_by(mail=email).first(): - author = Author(mail=email, is_banned=False) - db.session.add(author) - + if sendMailAndVerify(email):
@pan0303 This checks email validity before adding the author. Why don't you also check email validity before one posts an article? -Hui
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
验证邮箱是否真实有效并发送邮件或提示