Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201732120118-ljx improvements #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

421281726
Copy link

@421281726 421281726 commented Dec 5, 2020

What kind of change does this PR introduce?

Improvements:

  1. Generate a requirements.txt so that others could install necessary pip packages by one command:
    pip install -r requirements.txt

  2. The following JS file is not accessible but is still there, which will cause the page to load for a long time. I have comment it out.Or you can use correct site and move all js before like 3. .
    <script src="https://use.fontawesome.com/releases/v5.0.8/js/all.js"></script>

  3. Scripts can block downloads of other resources, so it is recommended to place all tags as far as possible
    at the bottom before the tag to minimize the impact on the overall page download.

    Now the page loads really fast.Without any waiting even with proxy!(slow for 2. and 3. before)

  4. Record IP addresses
    As it has recorded all IP address and could be banned, the administrator should have a page to see it and ban invalid IP address.
    I add an table to control if banned invalid visitor's ip in admin.html.

  5. In the /templates/domain.html
    body style="background-color:#dadada;"> " missing a '<' " , syntax error.

  6. Format the file service.py
    Make code more readable.

Does this PR introduce a breaking change?

No, just some simple change but good behavior

Other information:

assign: @hema-001 @spm2020spring

@421281726
Copy link
Author

421281726 commented Dec 5, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant