Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NIF to use KZG functions #780

Merged
merged 54 commits into from
Mar 6, 2024

Conversation

Godspower-Eze
Copy link
Contributor

Closes #746

@Godspower-Eze Godspower-Eze requested a review from a team as a code owner February 19, 2024 18:42
@Godspower-Eze Godspower-Eze marked this pull request as draft February 19, 2024 18:43
@Godspower-Eze Godspower-Eze marked this pull request as ready for review February 23, 2024 23:18
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Left some minor comments.

lib/types/mod.ex Outdated Show resolved Hide resolved
native/kzg_nif/Cargo.toml Outdated Show resolved Hide resolved
native/kzg_nif/Cargo.toml Outdated Show resolved Hide resolved
native/kzg_nif/src/lib.rs Show resolved Hide resolved
native/kzg_nif/src/lib.rs Outdated Show resolved Hide resolved
native/kzg_nif/src/lib.rs Show resolved Hide resolved
Godspower-Eze and others added 4 commits March 6, 2024 14:38
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
@mpaulucci mpaulucci added the deneb Features related to the deneb hard fork label Mar 6, 2024
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@MegaRedHand MegaRedHand merged commit dccee9d into lambdaclass:main Mar 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deneb Features related to the deneb hard fork
Projects
Development

Successfully merging this pull request may close these issues.

Add NIF to use KZG functions
3 participants