Breakup sql 4714 #85
Breakup sql 4714 #85
Conversation
…o improve performance.
Upstream changes which remove mapping related files
| -------------------------------------------------------------------------------- | ||
|
|
||
| BEGIN | ||
| PMN_DROPSQL('DROP TABLE enrollment'); |
There was a problem hiding this comment.
That is an update we had talked about and that I would like to make, but time constraints are pushing me to wrap this up for now. Perhaps we can make a note of it and revisit.
| @@ -0,0 +1,1000 @@ | |||
|
|
|||
There was a problem hiding this comment.
Fair enough, I will add a header
Oracle/PCORNetInit.sql
Outdated
|
|
||
|
|
||
| -------------------------------------------------------------------------------- | ||
| -- I2P REPORT |
There was a problem hiding this comment.
I think I saw something in the SCILHS issue tracker that I2P REPORT is now dead code. I'd prefer not to maintain it. Move it to its own file?
There was a problem hiding this comment.
This issue? If it is dead code, I'd just assume remove it all together.
| @@ -896,7 +158,9 @@ union --6 -- NS, NR, nH | |||
| begin | |||
| pcornet_popcodelist; | |||
|
|
|||
| PMN_DROPSQL('drop index demographic_patid'); | |||
| PMN_DROPSQL('drop index demographic_idx'); | |||
There was a problem hiding this comment.
As we discussed, I doubt consolidating indexes is a good idea.
| @@ -924,12 +188,26 @@ ORA-00904: "FACILITY_ID": invalid identifier | |||
| ORA-00904: "LOCATION_ZIP": invalid identifier | |||
| */ | |||
| create or replace procedure PCORNetEncounter as | |||
|
|
|||
| sqltext varchar2(4000); | |||
There was a problem hiding this comment.
yay! no more sqltext in procedure PCORNetEncounter
| @@ -1495,137 +719,70 @@ end PCORNetHarvest; | |||
|
|
|||
|
|
|||
|
|
|||
| /* TODO: When compiling PCORNetPrescribing, I got Error(93,15): | |||
Oracle/PCORNetLoader_ora.sql
Outdated
| END; | ||
| create or replace PROCEDURE PCORNetLoader(start_with VARCHAR2) AS | ||
| begin | ||
| if start_with in ('PCORNetDemographic') then |
There was a problem hiding this comment.
suggest: add a comment to acknowledge that this pile of if statements is ugly
There was a problem hiding this comment.
Agree, this could use some documentation.
Oracle/PCORNetLoader_ora.sql
Outdated
| PCORNetEncounter; | ||
| end if; | ||
|
|
||
| if start_with in ( |
There was a problem hiding this comment.
perhaps map start_with to a number called, let's say start_with_step and use start_with_step <= 3?
There was a problem hiding this comment.
Yeah, this guy is magic string city. Your suggestion could clean this procedure up a bit w/ the right documentation. I'm a little hesitant to do so because the name wouldn't get logged in the Jenkins console, but I know if that's a strong reason not to.
There was a problem hiding this comment.
The map-to-number idea was for inside this procedure; the jenkins logs wouldn't change, if I understand things correctly. But the destabilization risk is probably not worthwhile at this point.
This update to the code does the following:
PCORNetLoader.sqlinto a new filePCORNetInit.sqlso that preparing the transform space is separated from running the transform.