Webhook integration tests and clean up MatchCondition validation code #957
+1,636
−939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanz
force-pushed
the
enable-webhooks
branch
from
a550b03 to
6a28e18
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
==========================================
+ Coverage 67.35% 71.10% +3.74%
==========================================
Files 30 30
Lines 3128 3440 +312
==========================================
+ Hits 2107 2446 +339
+ Misses 852 836 -16
+ Partials 169 158 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvanz
force-pushed
the
enable-webhooks
branch
from
4b5c7cb to
7d2da13
Compare
|
@fabriziosestito this is not exactly what I want to show you because I still have the new tests under the controller directory. But I could not finish the changes yet. Therefore, I'll leave it as it is now and continue next day. |
jvanz
force-pushed
the
enable-webhooks
branch
4 times, most recently
from
a40e45c to
e234cf3
Compare
Move the factories used in tests to build our types to the policies/v1 package. Therefore, all the tests under /api and /internal/controller directories can use them. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
jvanz
force-pushed
the
enable-webhooks
branch
from
015fd4a to
35315b5
Compare
jvanz
changed the title
Adds tests to ensure that the function used by the webhooks server is calling the correct validation functions. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
jvanz
force-pushed
the
enable-webhooks
branch
from
35315b5 to
533f54e
Compare
jvanz
changed the title
Moves the code from policy_validation_matchconditions.go file into policy_validation.go file, removing the unnecessary code. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
jvanz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests to ensure that the function used by the webhooks server is calling the correct validation functions and moves the code from policy_validation_matchconditions.go file into policy_validation.go file, removing the unnecessary code.
Fix #824
Test
make test