chore(tests): move types factories to policies/v1 package.

Move the factories used in tests to build our types to the policies/v1
package. Therefore, all the tests under /api and /internal/controller
directories can use them.

Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>

api/policies/v1/admissionpolicy_webhook_test.go

@@ -23,31 +23,31 @@ import (
 )
 
 func TestAdmissionPolicyDefault(t *testing.T) {
-	policy := admissionPolicyFactory()
+	policy := AdmissionPolicy{}
 	policy.Default()
 
 	require.Equal(t, constants.DefaultPolicyServer, policy.GetPolicyServer())
 	require.Contains(t, policy.GetFinalizers(), constants.KubewardenFinalizer)
 }
 
 func TestAdmissionPolicyValidateCreate(t *testing.T) {
-	policy := admissionPolicyFactory()
+	policy := NewAdmissionPolicyFactory().Build()
 	warnings, err := policy.ValidateCreate()
 	require.NoError(t, err)
 	require.Empty(t, warnings)
 }
 
 func TestAdmissionPolicyValidateUpdate(t *testing.T) {
-	oldPolicy := admissionPolicyFactory()
-	newPolicy := admissionPolicyFactory()
+	oldPolicy := NewAdmissionPolicyFactory().Build()
+	newPolicy := NewAdmissionPolicyFactory().Build()
 	warnings, err := newPolicy.ValidateUpdate(oldPolicy)
 	require.NoError(t, err)
 	require.Empty(t, warnings)
 }
 
 func TestAdmissionPolicyValidateUpdateWithInvalidOldPolicy(t *testing.T) {
-	oldPolicy := clusterAdmissionPolicyFactory(nil, nil, "", "protect")
-	newPolicy := admissionPolicyFactory()
+	oldPolicy := NewClusterAdmissionPolicyFactory().Build()
+	newPolicy := NewAdmissionPolicyFactory().Build()
 	warnings, err := newPolicy.ValidateUpdate(oldPolicy)
 	require.Empty(t, warnings)
 	require.ErrorContains(t, err, "object is not of type AdmissionPolicy")

api/policies/v1/admissionpolicygroup_webhook_test.go

@@ -23,22 +23,22 @@ import (
 )
 
 func TestAdmissionPolicyGroupDefault(t *testing.T) {
-	policy := admissionPolicyGroupFactory()
+	policy := AdmissionPolicyGroup{}
 	policy.Default()
 
 	require.Equal(t, constants.DefaultPolicyServer, policy.GetPolicyServer())
 	require.Contains(t, policy.GetFinalizers(), constants.KubewardenFinalizer)
 }
 
 func TestAdmissionPolicyGroupValidateCreate(t *testing.T) {
-	policy := admissionPolicyGroupFactory()
+	policy := NewAdmissionPolicyGroupFactory().Build()
 	warnings, err := policy.ValidateCreate()
 	require.NoError(t, err)
 	require.Empty(t, warnings)
 }
 
 func TestClusterAdmissionPolicyValidateCreateWithNoMembers(t *testing.T) {
-	policy := admissionPolicyGroupFactory()
+	policy := NewAdmissionPolicyGroupFactory().Build()
 	policy.Spec.Policies = nil
 	warnings, err := policy.ValidateCreate()
 	require.Error(t, err)
@@ -47,16 +47,16 @@ func TestClusterAdmissionPolicyValidateCreateWithNoMembers(t *testing.T) {
 }
 
 func TestAdmissionPolicyGroupValidateUpdate(t *testing.T) {
-	oldPolicy := admissionPolicyGroupFactory()
-	newPolicy := admissionPolicyGroupFactory()
+	oldPolicy := NewAdmissionPolicyGroupFactory().Build()
+	newPolicy := NewAdmissionPolicyGroupFactory().Build()
 	warnings, err := newPolicy.ValidateUpdate(oldPolicy)
 	require.NoError(t, err)
 	require.Empty(t, warnings)
 }
 
 func TestAdmissionPolicyGroupValidateUpdateWithInvalidOldPolicy(t *testing.T) {
-	oldPolicy := clusterAdmissionPolicyGroupFactory()
-	newPolicy := admissionPolicyGroupFactory()
+	oldPolicy := NewClusterAdmissionPolicyGroupFactory().Build()
+	newPolicy := NewAdmissionPolicyGroupFactory().Build()
 	warnings, err := newPolicy.ValidateUpdate(oldPolicy)
 	require.Empty(t, warnings)
 	require.ErrorContains(t, err, "object is not of type AdmissionPolicyGroup")

api/policies/v1/clusteradmissionpolicy_webhook_test.go

@@ -23,31 +23,31 @@ import (
 )
 
 func TestClusterAdmissionPolicyDefault(t *testing.T) {
-	policy := clusterAdmissionPolicyFactory(nil, nil, "", "protect")
+	policy := ClusterAdmissionPolicy{}
 	policy.Default()
 
 	require.Equal(t, constants.DefaultPolicyServer, policy.GetPolicyServer())
 	require.Contains(t, policy.GetFinalizers(), constants.KubewardenFinalizer)
 }
 
 func TestClusterAdmissionPolicyValidateCreate(t *testing.T) {
-	policy := clusterAdmissionPolicyFactory(nil, nil, "", "protect")
+	policy := NewClusterAdmissionPolicyFactory().Build()
 	warnings, err := policy.ValidateCreate()
 	require.NoError(t, err)
 	require.Empty(t, warnings)
 }
 
 func TestClusterAdmissionPolicyValidateUpdate(t *testing.T) {
-	oldPolicy := clusterAdmissionPolicyFactory(nil, nil, "", "protect")
-	newPolicy := clusterAdmissionPolicyFactory(nil, nil, "", "protect")
+	oldPolicy := NewClusterAdmissionPolicyFactory().Build()
+	newPolicy := NewClusterAdmissionPolicyFactory().Build()
 	warnings, err := newPolicy.ValidateUpdate(oldPolicy)
 	require.NoError(t, err)
 	require.Empty(t, warnings)
 }
 
 func TestClusterAdmissionPolicyValidateUpdateWithInvalidOldPolicy(t *testing.T) {
-	oldPolicy := admissionPolicyFactory()
-	newPolicy := clusterAdmissionPolicyFactory(nil, nil, "", "protect")
+	oldPolicy := NewAdmissionPolicyFactory().Build()
+	newPolicy := NewClusterAdmissionPolicyFactory().Build()
 	warnings, err := newPolicy.ValidateUpdate(oldPolicy)
 	require.Empty(t, warnings)
 	require.ErrorContains(t, err, "object is not of type ClusterAdmissionPolicy")

api/policies/v1/clusteradmissionpolicygroup_webhook_test.go

@@ -23,22 +23,22 @@ import (
 )
 
 func TestClusterClusterAdmissionPolicyDefault(t *testing.T) {
-	policy := clusterAdmissionPolicyGroupFactory()
+	policy := ClusterAdmissionPolicyGroup{}
 	policy.Default()
 
 	require.Equal(t, constants.DefaultPolicyServer, policy.GetPolicyServer())
 	require.Contains(t, policy.GetFinalizers(), constants.KubewardenFinalizer)
 }
 
 func TestClusterClusterAdmissionPolicyValidateCreate(t *testing.T) {
-	policy := clusterAdmissionPolicyGroupFactory()
+	policy := NewClusterAdmissionPolicyGroupFactory().Build()
 	warnings, err := policy.ValidateCreate()
 	require.NoError(t, err)
 	require.Empty(t, warnings)
 }
 
 func TestClusterClusterAdmissionPolicyValidateCreateWithNoMembers(t *testing.T) {
-	policy := clusterAdmissionPolicyGroupFactory()
+	policy := NewClusterAdmissionPolicyGroupFactory().Build()
 	policy.Spec.Policies = nil
 	warnings, err := policy.ValidateCreate()
 	require.Error(t, err)
@@ -47,16 +47,16 @@ func TestClusterClusterAdmissionPolicyValidateCreateWithNoMembers(t *testing.T)
 }
 
 func TestClusterClusterAdmissionPolicyValidateUpdate(t *testing.T) {
-	oldPolicy := clusterAdmissionPolicyGroupFactory()
-	newPolicy := clusterAdmissionPolicyGroupFactory()
+	oldPolicy := NewClusterAdmissionPolicyGroupFactory().Build()
+	newPolicy := NewClusterAdmissionPolicyGroupFactory().Build()
 	warnings, err := newPolicy.ValidateUpdate(oldPolicy)
 	require.NoError(t, err)
 	require.Empty(t, warnings)
 }
 
 func TestClusterClusterAdmissionPolicyValidateUpdateWithInvalidOldPolicy(t *testing.T) {
-	oldPolicy := admissionPolicyGroupFactory()
-	newPolicy := clusterAdmissionPolicyGroupFactory()
+	oldPolicy := NewAdmissionPolicyGroupFactory().Build()
+	newPolicy := NewClusterAdmissionPolicyGroupFactory().Build()
 	warnings, err := newPolicy.ValidateUpdate(oldPolicy)
 	require.Empty(t, warnings)
 	require.ErrorContains(t, err, "object is not of type ClusterAdmissionPolicyGroup")