Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix, botreview, strategy: ignore unrelated files in kubevirtci-bump #3123

Closed
wants to merge 1 commit into from
Closed

fix, botreview, strategy: ignore unrelated files in kubevirtci-bump #3123

wants to merge 1 commit into from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Dec 12, 2023

Previously all files were added as unwanted whenever a review was placed, even if there we no files related to kubevirtci-bump at all in the patch set.

Now the review for kubevirtci-bump is only attached if there are relevant files in the PR.

/cc @brianmcarey

@dhiller
fix, botreview, strategy: ignore unrelated files in kubevirtci-bump
8f1229f 
Previously all files were added as unwanted whenever a review was
placed, even if there we no files related to kubevirtci-bump at all in
the patch set.

Now the review for kubevirtci-bump is only attached if there are
relevant files in the PR.

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 12, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dhiller. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhiller dhiller mentioned this pull request Dec 13, 2023
Merged
@dhiller
Copy link
Contributor Author

dhiller commented Dec 14, 2023

/hold

I am going to put this together with #3124 since it has a fix for kubevirtci-bump

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2023
@dhiller
Copy link
Contributor Author

dhiller commented Dec 14, 2023

/close

#3124

@kubevirt-bot
Copy link
Contributor

@dhiller: Closed this PR.

In response to this:

/close

#3124

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey Awaiting requested review from brianmcarey

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhiller @kubevirt-bot