Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP DNM, try the new lane #1811

Closed
wants to merge 4 commits into from
Closed

WIP DNM, try the new lane #1811

wants to merge 4 commits into from

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Jun 18, 2024

What this PR does / why we need it:

Special notes for your reviewer:

Release note:


@kubevirt-bot
Copy link
Collaborator

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 18, 2024
@kubevirt-bot kubevirt-bot requested review from phoracek and qinqon June 18, 2024 11:11
@kubevirt-bot kubevirt-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 18, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oshoval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval oshoval marked this pull request as draft June 18, 2024 13:00
@oshoval oshoval force-pushed the ipam_try branch 4 times, most recently from 201922b to 91fa968 Compare June 18, 2024 14:11
@oshoval oshoval marked this pull request as ready for review June 18, 2024 14:11
@oshoval
Copy link
Collaborator Author

oshoval commented Jun 18, 2024

/test pull-e2e-cluster-network-addons-operator-macvtap-cni-functests

@oshoval
Copy link
Collaborator Author

oshoval commented Jun 19, 2024

oshoval added 4 commits June 19, 2024 10:44
Signed-off-by: Or Shoval <oshoval@redhat.com>
Signed-off-by: Or Shoval <oshoval@redhat.com>
Without it, we don't have memory for some virtual machines.

Signed-off-by: Or Shoval <oshoval@redhat.com>
Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot
Copy link
Collaborator

@oshoval: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-cluster-network-addons-operator-workflow-k8s 3837125 link true /test pull-e2e-cluster-network-addons-operator-workflow-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@oshoval oshoval marked this pull request as draft June 19, 2024 09:26
@oshoval oshoval closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants