-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "should allow to preempt the lower priority group" test. #3921
Fix "should allow to preempt the lower priority group" test. #3921
Conversation
Skipping CI for Draft Pull Request. |
/test all 1 of 5 |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/test all 2 of 5 |
/test all 3 of 5 |
/test all 4 of 5 |
/test all 5 of 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this.
Could you clarify the reason why this case periodically failed so that we can understand this fixing solution (extending timeout)?
Sometimes, the garbage collector takes more than 5 seconds to delete a finalized Pod. That's why we need to increase the timeout to ensure that the Pods are deleted. |
Thank you. That makes sense. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 717916c1851274452270e903ca682bc323da1610
|
What type of PR is this?
/kind bug
/kind failing-test
/kind flake
What this PR does / why we need it:
Fix "Pod groups when Single CQ should allow to preempt the lower priority group" flaky test.
Which issue(s) this PR fixes:
Fixes #3915
Special notes for your reviewer:
Does this PR introduce a user-facing change?