Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "should allow to preempt the lower priority group" test. #3921

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind bug
/kind failing-test
/kind flake

What this PR does / why we need it:

Fix "Pod groups when Single CQ should allow to preempt the lower priority group" flaky test.

Which issue(s) this PR fixes:

Fixes #3915

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. labels Jan 2, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2025
@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Jan 2, 2025

/test all

1 of 5

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 2, 2025
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 19dbf6f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6776be0f82673000085fa9eb
😎 Deploy Preview https://deploy-preview-3921--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/test all

2 of 5

@mbobrovskyi
Copy link
Contributor Author

/test all

3 of 5

@mbobrovskyi
Copy link
Contributor Author

/test all

4 of 5

@mbobrovskyi
Copy link
Contributor Author

/test all

5 of 5

@mbobrovskyi mbobrovskyi marked this pull request as ready for review January 3, 2025 05:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mimowo January 3, 2025 05:06
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.
Could you clarify the reason why this case periodically failed so that we can understand this fixing solution (extending timeout)?

@mbobrovskyi
Copy link
Contributor Author

Thank you for working on this. Could you clarify the reason why this case periodically failed so that we can understand this fixing solution (extending timeout)?

Sometimes, the garbage collector takes more than 5 seconds to delete a finalized Pod. That's why we need to increase the timeout to ensure that the Pods are deleted.

@tenzen-y
Copy link
Member

tenzen-y commented Jan 6, 2025

Thank you for working on this. Could you clarify the reason why this case periodically failed so that we can understand this fixing solution (extending timeout)?

Sometimes, the garbage collector takes more than 5 seconds to delete a finalized Pod. That's why we need to increase the timeout to ensure that the Pods are deleted.

Thank you. That makes sense.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 717916c1851274452270e903ca682bc323da1610

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit b9a1e89 into kubernetes-sigs:main Jan 6, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test: Pod groups when Single CQ should allow to preempt the lower priority group
3 participants