Feat : 직위 추가 ddl 수정, 교직원 스크랩 로직 및 주기 변경 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbqmgldjfh
approved these changes
Dec 18, 2024
| return staffCompareSupport.compareAllDepartmentsAndUpdateExistStaff(scrapResults.kuStaffDTOMap(), originStaffStorage); | ||
| } | ||
|
|
||
| private void synchronizationWithDb(StaffCompareResults compareResults) { | ||
| System.out.println(compareResults.toString()); |
|
zbqmgldjfh
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
#149
📝작업 내용
1. ddl default 값 수정
이전 PR에서 default 값이 잘못 들어가서 "0"으로 들어가는 현상을 수정하기 위해 ddl수정했습니닷.
PR머지 전 dev 서버DB에서 flyway 기록 삭제, 만들어져있는 position column 삭제하려고 합니당
2. 이전까진 학과 이름이 변경된 경우 DB에서 조회 되지 않아 스크랩한 내용과 비교가 불가능해 삭제되지 않는 현상
이를 위해 DB에 있는 전체학과를 조회하여 비교하도록 구현했습니다. 로컬에서 정상적으로 비교, 삭제되는것 확인했습니다!
3. 교직원 스크랩 주기를 배포를 위해 30일로 다시 변경했습니닷