Scope Koin Modules to MainApplication

InsertKoinIO/koin#2078 (comment)
ksharma-xyz · Dec 25, 2024 · a3e91f5 · a3e91f5
1 parent c6cb884
commit a3e91f5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 18 deletions.
diff --git a/.idea/gradle.xml b/.idea/gradle.xml
diff --git a/app/src/main/java/xyz/ksharma/koinsingleton/MainActivity.kt b/app/src/main/java/xyz/ksharma/koinsingleton/MainActivity.kt
@@ -11,23 +11,20 @@ import androidx.compose.ui.Modifier
 import androidx.navigation.compose.NavHost
 import androidx.navigation.compose.composable
 import androidx.navigation.compose.rememberNavController
-import org.koin.android.ext.koin.androidContext
+import org.koin.androidx.compose.KoinAndroidContext
 import org.koin.androidx.compose.koinViewModel
-import org.koin.compose.KoinApplication
 import org.koin.core.module.dsl.viewModelOf
-import org.koin.dsl.koinConfiguration
 import org.koin.dsl.module
 import xyz.ksharma.koinsingleton.ui.theme.KoinSingletonBugTheme
 
-
 class MainActivity : ComponentActivity() {
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         enableEdgeToEdge()
         setContent {
             val navController = rememberNavController()
 
-            KoinApplication(application = koinConfig) {
+            KoinAndroidContext {
                 KoinSingletonBugTheme {
                     Scaffold(modifier = Modifier.fillMaxSize()) { innerPadding ->
                         NavHost(
@@ -53,14 +50,6 @@ class MainActivity : ComponentActivity() {
     }
 }
 
-val koinConfig = koinConfiguration {
-    modules(
-        repoModule,
-        viewModelsModule,
-    )
-    androidContext(MainApplication.instance ?: error("No Android application context set"))
-}
-
 val viewModelsModule = module {
     viewModelOf(::HomeViewModel)
     viewModelOf(::DetailViewModel)

diff --git a/app/src/main/java/xyz/ksharma/koinsingleton/MainApplication.kt b/app/src/main/java/xyz/ksharma/koinsingleton/MainApplication.kt
@@ -1,15 +1,19 @@
 package xyz.ksharma.koinsingleton
 
 import android.app.Application
+import org.koin.android.ext.koin.androidContext
+import org.koin.core.context.startKoin
 
 class MainApplication : Application() {
 
     override fun onCreate() {
         super.onCreate()
-        instance = this
-    }
-
-    companion object {
-        var instance: Application? = null
+        startKoin {
+            modules(
+                repoModule,
+                viewModelsModule,
+            )
+            androidContext(this@MainApplication)
+        }
     }
 }