Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KONFLUX-6398): fixes swapped pid and taskRunID #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StanislavJochman
Copy link

No description provided.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (88eafd6) to head (f6a5b66).

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #79    +/-   ##
========================================
  Coverage   80.15%   80.15%            
========================================
  Files         569      569            
  Lines       21391    21391            
  Branches     5291     5041   -250     
========================================
  Hits        17146    17146            
- Misses       4220     4221     +1     
+ Partials       25       24     -1     
Flag Coverage Δ
unittests 80.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

taskRun?.metadata?.uid,
pipelineRunUID,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you've changed the order of parameters and arguments as well, doe this PR changes something?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs testing because not on all places it is changed. But I do not have access to test it so trying to get that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants