Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KFLUXUI-125): allow sorting pipeline runs by status and type #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcin-michal
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/KFLUXUI-125

Description

Before, in the application's activity tab, it was only possible to sort pipeline runs by status, and in the snapshot's pipeline runs by type. Now, it's possible to sort by both of these attributes in either of the page, making it more consistent.

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

image
image
image

How to test or reproduce?

Go to the activity tab for any application and view the pipeline runs. To view the snapshots pipeline runs, click on any pipeline run from the previous page, click on the snapshot and select the pipeline runs tab.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 93.84615% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (7c5807c) to head (31eb20c).

Files with missing lines Patch % Lines
...neRun/PipelineRunListView/PipelineRunsListView.tsx 91.17% 2 Missing and 1 partial ⚠️
.../SnapshotDetails/tabs/SnapshotPipelineRunsList.tsx 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   80.01%   80.09%   +0.07%     
==========================================
  Files         569      569              
  Lines       21379    21435      +56     
  Branches     5294     5305      +11     
==========================================
+ Hits        17107    17168      +61     
+ Misses       4247     4242       -5     
  Partials       25       25              
Flag Coverage Δ
unittests 80.09% <93.84%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant