Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log activity when recording base image digests #1790

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

ralphbean
Copy link
Member

The purpose is just to help users debug failures in the future. I have one such failure now where a later step complains that these base image digest lines are malformed. I'm just trying to get visibility on that.

@ralphbean ralphbean requested a review from a team as a code owner January 6, 2025 19:22
@ralphbean
Copy link
Member Author

ralphbean commented Jan 6, 2025

FWIW, that other error I'm facing is:

[build-container : prepare-sboms] Merging contents of sbom-source.json and sbom-image.json into sbom-cyclonedx.json
[build-container : prepare-sboms] Merging contents of sbom-cachi2.json into sbom-cyclonedx.json
[build-container : prepare-sboms] Adding base images data to sbom-cyclonedx.json
[build-container : prepare-sboms] Traceback (most recent call last):
[build-container : prepare-sboms]   File "/scripts/base_images_sbom_script.py", line 354, in <module>
[build-container : prepare-sboms]     main()
[build-container : prepare-sboms]   File "/scripts/base_images_sbom_script.py", line 332, in main
[build-container : prepare-sboms]     base_images_digests = dict(item.split() for item in base_images_digests_raw)
[build-container : prepare-sboms]                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[build-container : prepare-sboms] ValueError: dictionary update sequence element #1 has length 1; 2 is required

In konflux-ci/yq-container#88

Edit: Ah, it was #1791!

@ralphbean ralphbean added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 6ac8f40 Jan 7, 2025
15 checks passed
@ralphbean ralphbean deleted the log-base-images branch January 10, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants