Setup CODEOWNERS

[chmeliik]

CODEOWNERS will allow us to make the ownership of individual tasks
actually mean something.

We will have to give every owner write permissions, but we will be able
to set up branch protection rules to block PRs from getting merged if
they don't have approvals from the owners.

This will allow the CODEOWNERS of tasks and stepactions to fully
self-service their PRs without giving them the ability to mess with
other parts of the repository.

[chmeliik]

TODO before this could be merged:

• Invite everyone in the CODEOWNERS file to konflux-ci and give them write permissions for this repo
• Address mismatches between the github teams and the teams defined in OWNERS_ALIASES

#!/bin/bash
set -o errexit -o nounset -o pipefail

export owners_alias=$1
gh_team=$2

owners=$(yq < OWNERS_ALIASES '.aliases[strenv(owners_alias)][]' | sort -u)
members=$(gh api orgs/konflux-ci/teams/"$gh_team"/members --jq '.[].login' | sort)

diff --color <(echo "$owners") <(echo "$members")

./compare-members.sh integration-team integration-service-maintainers
1a2
> chipspeak
4a6
> jencull

./compare-members.sh ec-team ec                                      
1d0
< cuipinghuo
4d2
< robnester-rh

And the build-maintainers GH team is not a good match for the build-team from OWNERS_ALIASES at all, TBD

[chmeliik]

Changed the CODEOWNERS based on #1658

Addressed the OWNERS_ALIASES vs. GH team mismatches

• build-maintainers matches the previous build-team now, minus the prefetch-only maintainers
• ec matches ec-team now
• integration-service-maintainers is integration-team + chipspeak, jencull (and those are integration team members, so that seems fine)

[chmeliik]

/retest

[chmeliik]

Need to add one more thing - Renovate groupings based on CODEOWNERS. Otherwise Renovate PRs will need approvals from many different sets of owners

[chmeliik]

CC @acornett21 @amisstea @arewm @avi-biton @bcrochet @brianwcook @brunoapimentel @cgwalters @eskultety @gbenhaim @gurnben @hmariset @jbpratt @kdudka @komish @ligangty @oamsalem @Omeramsc @ralphbean @scoheb @skattoju @taylormadore @yftacherzog @yma96

This PR adds you as a CODEOWNER (because you were already in an OWNERS file), which means you'll now have the power to self-service changes to your tasks. On the other hand, it means your approval will be required in order for those changes to be merged. Let me know if you have any concerns about that.

[chmeliik]

/test

[chmeliik]

Btw, the Renovate groupings based on filenames seem to work well. See for example chmeliik#45, chmeliik#46, which both update the oras image, but in two separate PRs according to the matchFileNames groupings

[chmeliik]

Added /task/validate-fbc and fixed the formatting (my auto-aligner script had a bug)

[tnevrlka]

🌮

[chmeliik]

/retest

[chmeliik]

There hasn't been pushback to this approach (or the pushback has been resolved). The CODEOWNERS file is now fully valid. Merging