Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snyk-sast: added stats for Snyk scans #1633

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jperezdealgaba
Copy link
Contributor

@jperezdealgaba jperezdealgaba commented Nov 21, 2024

Solves: https://issues.redhat.com/browse/OSH-769

Adding the stats to snyk scans in the result's SARIF file of successful scans.
Example of successful pipeline: https://konflux.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/application-pipeline/workspaces/jperezde/applications/test-coverity/pipelineruns/osh-cli-container-konflux-test-2-on-pull-request-znx98

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@openshift-ci openshift-ci bot requested review from dheerajodha and dirgim November 21, 2024 11:56
@jperezdealgaba jperezdealgaba force-pushed the snyk-stats-upstream branch 5 times, most recently from 3abcc0f to 72ce2f8 Compare November 21, 2024 12:10
@jperezdealgaba
Copy link
Contributor Author

I can not change reviewers/asignee
cc/ @kdudka @ralphbean

@kdudka
Copy link
Contributor

kdudka commented Nov 21, 2024

Me neither.

Copy link
Contributor

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed at jperezdealgaba#3.

@jperezdealgaba jperezdealgaba force-pushed the snyk-stats-upstream branch 2 times, most recently from f8f9df7 to c293a81 Compare December 6, 2024 10:26
@jperezdealgaba
Copy link
Contributor Author

@tnevrlka Would you mind enabling this pipeline please?

@tnevrlka
Copy link
Contributor

tnevrlka commented Dec 6, 2024

/ok-to-test

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jperezdealgaba
Copy link
Contributor Author

@dirgim Thanks for the thumbs up! Can this be merged?

Solves: https://issues.redhat.com/browse/OSH-769

Adding the stats to snyk scans in the result's SARIF file of successful scans.
@tnevrlka
Copy link
Contributor

tnevrlka commented Dec 6, 2024

/ok-to-test

@kdudka kdudka added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 9, 2024
@dirgim dirgim added this pull request to the merge queue Dec 9, 2024
Merged via the queue into konflux-ci:main with commit a50d7b3 Dec 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants