.tekton/pull-request: run conditionally #1188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested the expression in https://playcel.undistro.io/ with variations of the following input # Here is the input data in YAML or JSON format.
event: push
target_branch: gh-readonly-queue/main/
body:
pull_request:
draft: false
files:
all:
- "README.md"
- "renovate.json"
- ".github/workflows/checkton.yaml" |
MartinBasti
reviewed
Jul 24, 2024
.tekton/pull-request.yaml
Outdated
| @@ -17,7 +17,7 @@ metadata: | |||
| ) && ( | |||
| // Don't run pipeline if only these files changed. Note that 'files.all' is an object | |||
| // coming from PaC (list of all changed files) while the second 'all' is a CEL macro. | |||
| !files.all.all(x, x.matches(r"^(renovate\.json|.*\.md|\.github/.*)$")) | |||
| !files.all.all(x, x.matches(r"^(renovate\.json|.*\.md|\.github/.*|\.tekton/.*)$")) | |||
There was a problem hiding this comment.
Why do we want to exclude .tekton?
I'd like to see if changes in tekton are valid and will pass testing before merging them
There was a problem hiding this comment.
Yeah I'm just testing if the exclusion works (and found out that Red Hat Konflux / build-definitions-pull-request somehow became a required check, so we'll need to disable that)
There was a problem hiding this comment.
\o/ thanks @arewm for removing the required check, now PRs wil no longer be blocked in cases where the .tekton/pull-request pipeline doesn't need to run
There was a problem hiding this comment.
Dropped the temp commit, ready for review
Also add comments. Signed-off-by: Adam Cmiel <acmiel@redhat.com>
Don't run the pipeline if the only changed files are - *.md - .github/* - renovate.json Signed-off-by: Adam Cmiel <acmiel@redhat.com>
chmeliik
force-pushed
the
selective-tekton-pipeline
branch
2 times, most recently
from
a94b09a to
75cebe2
Compare
|
As @arewm found out, making the Konflux pipeline a not-required check means that if you press the There have been many requests for GitHub to make the "required check is skippable" behavior sane (https://github.com/orgs/community/discussions/13690), but until that happens, we can't go with this approach. |
|
Perhaps this could be an enhancement in Pipelines as Code, mark skipped Pipelines as successful? |
|
openshift-pipelines/pipelines-as-code#1746 if anyone wants to follow up with comments. |
Nice, thanks for filing that. For our use case, we can probably add something to the pipeline to skip just the e2e-tests task, as that's the main one we really care about. But this does seem like it could be a useful generic PaC feature |
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Oct 31, 2024
The new Task in `.tekton/tasks/changed-dirs.yaml` produces a list of changed directories for a particular pull request as an array result. Given this result guards can be done, e.g. using CEL expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 11, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 11, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 11, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 11, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 11, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 11, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 11, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 11, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 11, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 12, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Nov 14, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in #1188 and #524, with the distinction that the PipelineRun is executed, only potentially not in full.
ligangty
pushed a commit
to ligangty/build-definitions
that referenced
this pull request
Nov 21, 2024
The new Task in `.tekton/tasks/task-switchboard.yaml` produces a list of bindings that evaluate to true for a particular pull request as an array result. Given this result guards can be done, e.g. using when expressions to limit when a Task on the Pipeline needs to run. This way we can skip expensive Tasks that are unrelated to the change done in the pull request. Similar to work in konflux-ci#1188 and konflux-ci#524, with the distinction that the PipelineRun is executed, only potentially not in full.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't run the pipeline if the only changed files are
*.md.github/*renovate.jsonNote that a similar attempt was made in #524, which took the approach of enumerating every file/directory which should trigger the pipeline (maybe
files.allwasn't available at the time). This PR takes the opposite approach.