Skip to content

Commit

Permalink
sast-shell-check-oci-ta: rename "PROJECT_NVR" to "PROJECT_NAME" for c…
Browse files Browse the repository at this point in the history
…onsistency
  • Loading branch information
rhyw committed Oct 30, 2024
1 parent 8b90b5d commit fd03a18
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion task/sast-shell-check-oci-ta/0.1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ShellCheck is a static analysis tool, gives warnings and suggestions for bash/sh
|CACHI2_ARTIFACT|The Trusted Artifact URI pointing to the artifact with the prefetched dependencies.|""|false|
|IMP_FINDINGS_ONLY|Whether to include important findings only|true|false|
|KFP_GIT_URL|git repository to download known false positives files from|""|false|
|PROJECT_NVR|Name-Version-Release (NVR) of the scanned project, used to find path exclusions|""|false|
|PROJECT_NAME|Name of the scanned project, used to find path exclusions. By default, the Konflux component name will be used.|""|false|
|RECORD_EXCLUDED|Whether to record the excluded findings (default to false). If `true`, the excluded findings will be stored in `excluded-findings.json`. |false|false|
|SOURCE_ARTIFACT|The Trusted Artifact URI pointing to the artifact with the application source code.||true|
|caTrustConfigMapKey|The name of the key in the ConfigMap that contains the CA bundle data.|ca-bundle.crt|false|
Expand Down
16 changes: 8 additions & 8 deletions task/sast-shell-check-oci-ta/0.1/sast-shell-check-oci-ta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ spec:
from
type: string
default: ""
- name: PROJECT_NVR
description: Name-Version-Release (NVR) of the scanned project, used
to find path exclusions
- name: PROJECT_NAME
description: Name of the scanned project, used to find path exclusions.
By default, the Konflux component name will be used.
type: string
default: ""
- name: RECORD_EXCLUDED
Expand Down Expand Up @@ -89,8 +89,8 @@ spec:
env:
- name: KFP_GIT_URL
value: $(params.KFP_GIT_URL)
- name: PROJECT_NVR
value: $(params.PROJECT_NVR)
- name: PROJECT_NAME
value: $(params.PROJECT_NAME)
- name: RECORD_EXCLUDED
value: $(params.RECORD_EXCLUDED)
- name: IMP_FINDINGS_ONLY
Expand Down Expand Up @@ -157,9 +157,9 @@ spec:
--kfp-git-url="${KFP_GIT_URL}"
)
# Append --project-nvr option if PROJECT_NVR is set
if [ -n "${PROJECT_NVR}" ]; then
csfilter_kfp_cmd+=(--project-nvr="${PROJECT_NVR}")
# Append --project-nvr option if PROJECT_NAME is set
if [ -n "${PROJECT_NAME}" ]; then
csfilter_kfp_cmd+=(--project-nvr="${PROJECT_NAME}")
fi
if [[ "${RECORD_EXCLUDED}" == "true" ]]; then
Expand Down

0 comments on commit fd03a18

Please sign in to comment.