Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permissions): restore edit functionality for users with partial permissions TASK-1366 #5351

Merged

Conversation

noliveleger
Copy link
Contributor

📣 Summary

Fixed an issue where users with partial permissions could no longer edit submissions they were allowed to.

📖 Description

Users with partial permissions faced an issue where they were unable to edit submissions they had proper access to. This fix resolves the problem, allowing these users to edit submissions within their permissions scope, while maintaining the integrity of restricted resources.

👀 Preview steps

Bug template:

  1. Create a project
  2. Give another user partial permissions: edit their data
  3. Submit data with the other user
  4. Edit the data the other user
  5. 🔴 [on release branch] Receive a 403 in enketo
  6. 🟢 [on PR] Edit is successful

@noliveleger noliveleger self-assigned this Dec 12, 2024
@noliveleger noliveleger changed the title fix(permissions): restore edit functionality for users with partial permissions fix(permissions): restore edit functionality for users with partial permissions TASK-1366 Dec 12, 2024
Copy link
Contributor

@Guitlle Guitlle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noliveleger noliveleger merged commit 534edaf into release/2.024.36 Dec 16, 2024
6 checks passed
@noliveleger noliveleger deleted the task-1366-user-with-partial-perms-cannot-edit branch December 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants