Merge pull request #28 from kitesjs/dev-xoptions

Dev extension options

packages/common/README.md

@@ -9,16 +9,6 @@ Template-based Web Application Framework
 
 **Kites** is a framework providing `dynamic applications` assembling and `Template-based` extracting. Namely it contains a lot of templates and extensions to help building a new application quickly.
 
-Take a look at this:
-
-```ts
-@Launcher({
-  imports?: [], // ... kites extensions manually imported here
-  discover?: Array<string> | string | boolean; // autodiscover extensions in app's child directories or given path
-})
-class App {}
-```
-
 Features
 =======
 

packages/core/README.md

@@ -9,16 +9,6 @@ Template-based Web Application Framework
 
 **Kites** is a framework providing `dynamic applications` assembling and `Template-based` extracting. Namely it contains a lot of templates and extensions to help building a new application quickly.
 
-Take a look at this:
-
-```ts
-@Launcher({
-  imports?: [], // ... kites extensions manually imported here
-  discover?: Array<string> | string | boolean; // autodiscover extensions in app's child directories or given path
-})
-class App {}
-```
-
 Features
 =======
 

packages/core/engine/kites-instance.spec.ts

@@ -83,6 +83,9 @@ describe('kites engine', () => {
     }).init();
 
     expect(app.aKitesExtensionInitialized).eq(true, 'found a kites extension which has initialized!');
+    expect(app.options.sample).eql({
+      always: 'be here'
+    }, 'read extension options!');
   });
 
   it('should accept plain function as an extension', async () => {

packages/core/extensions/extensions-manager.ts

@@ -108,11 +108,14 @@ class ExtensionsManager extends EventEmitter {
   private useOne(extension: KitesExtension) {
     // extends options
     // Review _.assign(), _.defaults(), or _.merge?
+    const xname = extension.name && extension.name.toLowerCase();
     const options = _.assign<
       ExtensionOptions,
       ExtensionOptions | undefined,
-      ExtensionOptions | undefined>({}, extension.options, this.kites.options[extension.name && extension.name.toLowerCase()]);
+      ExtensionOptions | undefined>({}, extension.options, this.kites.options[xname]);
+
     extension.options = options;
+    this.kites.options[xname] = options;
 
     if (options.enabled === false) {
       this.kites.logger.debug(`Extension ${extension.name} is disabled, skipping`);

packages/core/test/extensions/sample-extension/kites.config.js

@@ -0,0 +1,9 @@
+module.exports = {
+  name: 'sample',
+  main: 'main.js',
+  dependencies: [],
+  hasPublicPart: false,
+  options: {
+    always: 'be here'
+  }
+}

packages/core/test/extensions/a-kites-extension/main.js → packages/core/test/extensions/sample-extension/main.js

@@ -1,3 +1,3 @@
 module.exports = function (kites, definition) {
-    kites.aKitesExtensionInitialized = true
-}
+  kites.aKitesExtensionInitialized = true;
+}

packages/express/README.md

@@ -9,16 +9,6 @@ Template-based Web Application Framework
 
 **Kites** is a framework providing `dynamic applications` assembling and `Template-based` extracting. Namely it contains a lot of templates and extensions to help building a new application quickly.
 
-Take a look at this:
-
-```ts
-@Launcher({
-  imports?: [], // ... kites extensions manually imported here
-  discover?: Array<string> | string | boolean; // autodiscover extensions in app's child directories or given path
-})
-class App {}
-```
-
 Features
 =======
 

packages/rest/README.md

@@ -9,16 +9,6 @@ Template-based Web Application Framework
 
 **Kites** is a framework providing `dynamic applications` assembling and `Template-based` extracting. Namely it contains a lot of templates and extensions to help building a new application quickly.
 
-Take a look at this:
-
-```ts
-@Launcher({
-  imports?: [], // ... kites extensions manually imported here
-  discover?: Array<string> | string | boolean; // autodiscover extensions in app's child directories or given path
-})
-class App {}
-```
-
 Features
 =======