Preventing non-return on non-void; changing printf format #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing non-return on non-void function:
The compiler is unaware that there are only two valid inputs for the definition Encoding.
Changing the bottom case to default shouldn't change anything functionally since BGR and RGB are the only valid encodings.
Changing printf %d to %lu for long unsigned int:
This throws a warning because %d is not the correct printf syntax for long unsigned ints.
%lu matches the C++ docs and removes the warning.