Checkup: Randomize ConfigMap name #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for the VMI under test and CM to have the same random suffix - move the randomization logic to the calling function. Signed-off-by: Orel Misan <omisan@redhat.com>
Currently, the ConfigMap that is used to inject the boot script to the VM under test has a constant name. This prevents running multiple instances of the checkup in one namespace simultaneously. Randomize the name, so the checkup could have multiple simultaneously running instances in a single namespace. Signed-off-by: Orel Misan <omisan@redhat.com>
|
Tested on an OpenShift Virtualization 4.16 cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ConfigMap that is used to inject the boot script to the VM under test has a constant name.
This prevents running multiple instances of the checkup in one namespace simultaneously.
Randomize the name, so the checkup could have multiple simultaneously running instances in a single namespace.