Make VM image mandatory #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, vmUnderTestContainerDiskImage defaults to: `quay.io/kiagnose/kubevirt-realtime-checkup-vm:main`. This may lead to unexpected behavior when using an older checkup version in combination with the latest VM container disk image (tagged as `main`). Make the field mandatory in order for the user to specify it explicitly. Signed-off-by: Orel Misan <omisan@redhat.com>
Following the previous commit, adjust the documentation accordingly. Signed-off-by: Orel Misan <omisan@redhat.com>
|
Tested on an OpenShift Virtualization 4.16 cluster. |
orelmisan
added a commit
to orelmisan/kubevirt-realtime-checkup
that referenced
this pull request
Apr 8, 2024
PR kiagnose#65 made vmUnderTestContainerDiskImage mandatory. Adjust the checkup tests to reflect this change. Signed-off-by: Orel Misan <omisan@redhat.com>
orelmisan
added a commit
that referenced
this pull request
Apr 8, 2024
PR #65 made vmUnderTestContainerDiskImage mandatory. Adjust the checkup tests to reflect this change. Signed-off-by: Orel Misan <omisan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, vmUnderTestContainerDiskImage defaults to:
quay.io/kiagnose/kubevirt-realtime-checkup-vm:main.This may lead to unexpected behavior when using an older checkup version in combination with the latest VM container disk image (tagged as
main).Make the field mandatory in order for the user to specify it explicitly.