Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMI spec: Always pull container disk image #47

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

orelmisan
Copy link
Member

Currently, the ImagePullPolicy on the container disk image is undefined, thus defaults to IfNotPresent [1].

Since we are using a single tag to represent the current state of the main branch, the image is not pulled again when there are updates to the VM under test's container disk image.

Set the ImagePullPolicy to Always[2].

[1] https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting
[2] https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy

Currently, the ImagePullPolicy on the container disk image
is undefined, thus defaults to `IfNotPresent` [1].

Since we are using a single tag to represent the current
state of the `main` branch, the image is not pulled again
when there are updates to the VM under test's container disk image.

Set the ImagePullPolicy to `Always`[2].

[1] https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting
[2] https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy

Signed-off-by: Orel Misan <omisan@redhat.com>
@orelmisan orelmisan requested a review from RamLavi December 17, 2023 07:53
@orelmisan
Copy link
Member Author

Tested against an OpenShift Virtualization cluster v4.15.

Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@orelmisan orelmisan merged commit 3b1809c into kiagnose:main Dec 17, 2023
5 checks passed
@orelmisan orelmisan deleted the always-pull-container-disk-image branch December 17, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants