Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Bump go to 1.20.12 #44

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

orelmisan
Copy link
Member

@orelmisan orelmisan commented Dec 6, 2023

Use the default go image tag.
Bump the go mod tidy github action.

Use the default go image tag.
Bump the `go mod tidy` github action.

Signed-off-by: Orel Misan <omisan@redhat.com>
@RamLavi
Copy link
Collaborator

RamLavi commented Dec 6, 2023

Can we try this after we have a checkup running? Then the CI would be strong enough to tell us if this change is breaking anything

Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talked offline. it's important enough to get merged now
/lgtm

@orelmisan orelmisan merged commit 4085928 into kiagnose:main Dec 6, 2023
5 checks passed
@orelmisan orelmisan deleted the bump-go-1.20.12 branch December 6, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants