Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align user-facing API with the DPDK checkup #33

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

orelmisan
Copy link
Member

@orelmisan orelmisan commented Nov 13, 2023

Rename the targetNode parameter to vmUnderTestTargetNodeName.
Rename node output field to vmUnderTestActualNodeName.

Note: The README.md file is already up-to-date.

Rename the `targetNode` parameter to `vmUnderTestTargetNodeName`,
in order to align it with the DPDK checkup.

Signed-off-by: Orel Misan <omisan@redhat.com>
Rename `node` output field to `vmUnderTestActualNodeName`
in order to align it with the DPDK checkup.

Signed-off-by: Orel Misan <omisan@redhat.com>
@orelmisan orelmisan requested a review from RamLavi November 13, 2023 09:12
@orelmisan orelmisan mentioned this pull request Nov 13, 2023
Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@orelmisan orelmisan merged commit 6131001 into kiagnose:main Nov 13, 2023
5 checks passed
@orelmisan orelmisan deleted the align-user-facing-api branch November 13, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants