Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Transformers API Upgrade #824

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: Transformers API Upgrade #824

wants to merge 14 commits into from

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
Update transformers inference to align with VLLM. In addition ConversationalPipeline has been deprecated/no longer supported by transformers library so this has been removed.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rkspace/inference/text-generation/inference_api.py 72.41% 8 Missing ⚠️
Files with missing lines Coverage Δ
...erence/text-generation/tests/test_inference_api.py 100.00% <100.00%> (ø)
...ference/text-generation/tests/test_model_config.py 100.00% <100.00%> (ø)
...rkspace/inference/text-generation/inference_api.py 79.80% <72.41%> (-3.68%) ⬇️

... and 37 files with indirect coverage changes

Copy link
Collaborator

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants