-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade v1beta1.NodeClaim to v1.NodeClaim #823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
801c98b
to
61b809f
Compare
61b809f
to
d82e2b5
Compare
please update the installation docs as well. https://github.com/kaito-project/kaito/blob/main/docs/installation.md#install-helm-charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this is a general question, why is this package used "github.com/awslabs/operatorpkg/status" ? Instead of importing from karpenterv1?
d82e2b5
to
b16e5a1
Compare
karpenter v1.NodeClaim depends on |
|
1. upgrade v1beta1.NodeClaim to v1.NodeClaim in workspace/ragengine/e2e 2. upgrade sigs.k8s.io/karpenter from v0.36.2 to v1.0.4 3. upgrade github.com/Azure/karpenter-provider-azure from v0.5.4 to v0.7.0(the latest tag) 4. upgrade github.com/aws/karpenter-provider-aws from v0.36.2 to v1.0.6 5. upgrade golang to v1.23 because of Azure/karpenter-provider-azure v0.7.0 depends on golang v1.23 6. use gpu-provisioner v0.3.1(support v1.NodeClaim only) Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
b16e5a1
to
5883c94
Compare
could you please see if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us update installation guide and installed versioned workspace helm chart.
@bangqipropel I think that it's no problem to use https://raw.githubusercontent.com/Azure/gpu-provisioner/main/hack/deploy/configure-helm-values.sh for the installation. Did you have met any problems about this file? |
Reason for Change:
gpu-provisioner
v0.3.1 (support v1.NodeClaim only)Requirements
Issue Fixed:
Notes for Reviewers: