Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade v1beta1.NodeClaim to v1.NodeClaim #823

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

rambohe-ch
Copy link
Collaborator

@rambohe-ch rambohe-ch commented Jan 13, 2025

Reason for Change:

  1. upgrade v1beta1.NodeClaim to v1.NodeClaim in workspace/ragengine/e2e
  2. upgrade sigs.k8s.io/karpenter from v0.36.2 to v1.0.4
  3. upgrade github.com/Azure/karpenter-provider-azure from v0.5.4 to v0.7.0(the latest tag)
  4. upgrade github.com/aws/karpenter-provider-aws from v0.36.2 to v1.0.6
  5. upgrade golang to v1.23 because of Azure/karpenter-provider-azure v0.7.0 depends on golang v1.23
  6. use gpu-provisioner v0.3.1 (support v1.NodeClaim only)

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Jan 13, 2025

Copy link
Collaborator

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rambohe-ch rambohe-ch changed the title feat: upgrade v1beta1.NodeClaim to v1.NodeClaim [WIP] feat: upgrade v1beta1.NodeClaim to v1.NodeClaim Jan 14, 2025
@rambohe-ch rambohe-ch force-pushed the upgrade-v1-nodeclaim branch from 801c98b to 61b809f Compare January 14, 2025 00:59
@rambohe-ch rambohe-ch force-pushed the upgrade-v1-nodeclaim branch from 61b809f to d82e2b5 Compare January 15, 2025 02:42
@rambohe-ch rambohe-ch changed the title [WIP] feat: upgrade v1beta1.NodeClaim to v1.NodeClaim feat: upgrade v1beta1.NodeClaim to v1.NodeClaim Jan 15, 2025
@rambohe-ch
Copy link
Collaborator Author

截屏2025-01-15 15 36 30

As the above image, gpu-provisioner v0.3.1 is installed.

@zhuangqh
Copy link
Collaborator

please update the installation docs as well. https://github.com/kaito-project/kaito/blob/main/docs/installation.md#install-helm-charts

Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is a general question, why is this package used "github.com/awslabs/operatorpkg/status" ? Instead of importing from karpenterv1?

@rambohe-ch
Copy link
Collaborator Author

Ok, this is a general question, why is this package used "github.com/awslabs/operatorpkg/status" ? Instead of importing from karpenterv1?

karpenter v1.NodeClaim depends on github.com/awslabs/operatorpkg/status.

https://github.com/kubernetes-sigs/karpenter/blob/48b32a9a17979a8260f70e337c4b2c7bf51086c6/pkg/apis/v1/nodeclaim_status.go#L55C15-L55C21

@rambohe-ch
Copy link
Collaborator Author

please update the installation docs as well. https://github.com/kaito-project/kaito/blob/main/docs/installation.md#install-helm-charts

  1. gpu-provisioner version is upgraded to v0.3.1
  2. the version information is added in the important notes:

For Kaito 0.4.2 and above, please use gpu-provisioner 0.3.1 or higher. For versions below Kaito 0.4.2, please use gpu-provisioner 0.2.1.

1. upgrade v1beta1.NodeClaim to v1.NodeClaim in workspace/ragengine/e2e
2. upgrade sigs.k8s.io/karpenter from v0.36.2 to v1.0.4
3. upgrade github.com/Azure/karpenter-provider-azure from v0.5.4 to v0.7.0(the latest tag)
4. upgrade github.com/aws/karpenter-provider-aws from v0.36.2 to v1.0.6
5. upgrade golang to v1.23 because of Azure/karpenter-provider-azure v0.7.0 depends on golang v1.23
6. use gpu-provisioner v0.3.1(support v1.NodeClaim only)

Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
@rambohe-ch rambohe-ch force-pushed the upgrade-v1-nodeclaim branch from b16e5a1 to 5883c94 Compare January 15, 2025 05:48
@bangqipropel
Copy link
Collaborator

could you please see if
https://raw.githubusercontent.com/Azure/gpu-provisioner/main/hack/deploy/configure-helm-values.sh
still good for the install?
It is for the Makefile, just want to see if this will still be good or not

Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us update installation guide and installed versioned workspace helm chart.

@rambohe-ch
Copy link
Collaborator Author

could you please see if https://raw.githubusercontent.com/Azure/gpu-provisioner/main/hack/deploy/configure-helm-values.sh still good for the install? It is for the Makefile, just want to see if this will still be good or not

@bangqipropel I think that it's no problem to use https://raw.githubusercontent.com/Azure/gpu-provisioner/main/hack/deploy/configure-helm-values.sh for the installation. Did you have met any problems about this file?

@Fei-Guo Fei-Guo merged commit 03bf1b3 into main Jan 15, 2025
8 of 9 checks passed
@Fei-Guo Fei-Guo deleted the upgrade-v1-nodeclaim branch January 15, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants