Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tuning job update supporting #580

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Aug 27, 2024

Reason for Change:

  1. Update tuning jobs when tuning input or output changes are detected
  2. Add e2e tests
  3. Add unit test for update

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 57.58%. Comparing base (5c30038) to head (de452c0).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/workspace_controller.go 0.00% 13 Missing ⚠️
pkg/resources/manifests.go 0.00% 3 Missing ⚠️
pkg/tuning/preset-tuning.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   58.18%   57.58%   -0.61%     
==========================================
  Files          30       30              
  Lines        2987     2980       -7     
==========================================
- Hits         1738     1716      -22     
- Misses       1149     1164      +15     
  Partials      100      100              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bangqipropel bangqipropel force-pushed the bangqipropel/tuning_job_update branch from 6b5d861 to 2688875 Compare August 27, 2024 20:09
@bangqipropel bangqipropel changed the title feat: Tuning job update supporting[draft] feat: Tuning job update supporting Aug 27, 2024
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel force-pushed the bangqipropel/tuning_job_update branch from d23ca16 to 8a07832 Compare August 30, 2024 09:58
@bangqipropel bangqipropel force-pushed the bangqipropel/tuning_job_update branch from 8a07832 to a9b1817 Compare August 30, 2024 09:59
@bangqipropel bangqipropel force-pushed the bangqipropel/tuning_job_update branch from a9b1817 to 8d3e345 Compare August 30, 2024 10:29
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@bangqipropel bangqipropel merged commit 8785cc5 into main Aug 30, 2024
8 of 10 checks passed
@bangqipropel bangqipropel deleted the bangqipropel/tuning_job_update branch August 30, 2024 23:26
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Sep 18, 2024
**Reason for Change**:

1. Update tuning jobs when tuning input or output changes are detected
2. Add e2e tests
3. Add unit test for update

**Requirements**

- [ ] added unit tests and e2e tests (if applicable).

**Issue Fixed**:
<!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
line. -->

**Notes for Reviewers**:

---------

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Sep 18, 2024
**Reason for Change**:

1. Update tuning jobs when tuning input or output changes are detected
2. Add e2e tests
3. Add unit test for update

**Requirements**

- [ ] added unit tests and e2e tests (if applicable).

**Issue Fixed**:
<!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
line. -->

**Notes for Reviewers**:

---------

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants