-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tuning job update supporting #580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangqipropel
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
August 27, 2024 09:06
bangqipropel
temporarily deployed
to
unit-tests
August 27, 2024 09:06 — with
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 58.18% 57.58% -0.61%
==========================================
Files 30 30
Lines 2987 2980 -7
==========================================
- Hits 1738 1716 -22
- Misses 1149 1164 +15
Partials 100 100 ☔ View full report in Codecov by Sentry. |
bangqipropel
force-pushed
the
bangqipropel/tuning_job_update
branch
from
August 27, 2024 20:09
6b5d861
to
2688875
Compare
bangqipropel
temporarily deployed
to
unit-tests
August 27, 2024 20:09 — with
GitHub Actions
Inactive
bangqipropel
changed the title
feat: Tuning job update supporting[draft]
feat: Tuning job update supporting
Aug 27, 2024
Fei-Guo
approved these changes
Aug 27, 2024
bangqipropel
force-pushed
the
bangqipropel/tuning_job_update
branch
from
August 29, 2024 01:37
2688875
to
9f81e15
Compare
bangqipropel
had a problem deploying
to
unit-tests
August 29, 2024 01:39 — with
GitHub Actions
Error
bangqipropel
had a problem deploying
to
e2e-test
August 29, 2024 01:39 — with
GitHub Actions
Failure
bangqipropel
had a problem deploying
to
e2e-test
August 29, 2024 01:39 — with
GitHub Actions
Failure
bangqipropel
force-pushed
the
bangqipropel/tuning_job_update
branch
from
August 29, 2024 01:51
9f81e15
to
90b9258
Compare
bangqipropel
temporarily deployed
to
unit-tests
August 29, 2024 01:51 — with
GitHub Actions
Inactive
bangqipropel
had a problem deploying
to
unit-tests
August 29, 2024 19:43 — with
GitHub Actions
Error
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
bangqipropel
force-pushed
the
bangqipropel/tuning_job_update
branch
from
August 29, 2024 21:03
af1bf41
to
e4bc6a2
Compare
bangqipropel
had a problem deploying
to
unit-tests
August 29, 2024 21:03 — with
GitHub Actions
Error
bangqipropel
had a problem deploying
to
unit-tests
August 30, 2024 09:56 — with
GitHub Actions
Error
bangqipropel
force-pushed
the
bangqipropel/tuning_job_update
branch
from
August 30, 2024 09:58
d23ca16
to
8a07832
Compare
bangqipropel
had a problem deploying
to
unit-tests
August 30, 2024 09:58 — with
GitHub Actions
Error
bangqipropel
force-pushed
the
bangqipropel/tuning_job_update
branch
from
August 30, 2024 09:59
8a07832
to
a9b1817
Compare
bangqipropel
had a problem deploying
to
unit-tests
August 30, 2024 09:59 — with
GitHub Actions
Error
bangqipropel
force-pushed
the
bangqipropel/tuning_job_update
branch
from
August 30, 2024 10:29
a9b1817
to
8d3e345
Compare
bangqipropel
had a problem deploying
to
unit-tests
August 30, 2024 10:30 — with
GitHub Actions
Error
Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
bangqipropel
force-pushed
the
bangqipropel/tuning_job_update
branch
from
August 30, 2024 11:08
8d3e345
to
0eddc55
Compare
bangqipropel
had a problem deploying
to
e2e-test
August 30, 2024 11:08 — with
GitHub Actions
Failure
bangqipropel
temporarily deployed
to
unit-tests
August 30, 2024 11:08 — with
GitHub Actions
Inactive
ishaansehgal99
approved these changes
Aug 30, 2024
bangqipropel
temporarily deployed
to
unit-tests
August 30, 2024 21:15 — with
GitHub Actions
Inactive
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Sep 18, 2024
**Reason for Change**: 1. Update tuning jobs when tuning input or output changes are detected 2. Add e2e tests 3. Add unit test for update **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com> Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Sep 18, 2024
**Reason for Change**: 1. Update tuning jobs when tuning input or output changes are detected 2. Add e2e tests 3. Add unit test for update **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com> Co-authored-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Requirements
Issue Fixed:
Notes for Reviewers: