Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inference API cleanup #233

Merged
merged 31 commits into from
Feb 21, 2024
Merged

feat: inference API cleanup #233

merged 31 commits into from
Feb 21, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Feb 6, 2024

This PR does some cleanup on the inference API. Introduces:

  1. ModelConfig Dataclass
  2. Allow additional user args
  3. GenerateKwargs Model
  4. More descriptive comments/metadata for model fields
  5. Rename inference-api.py -> inference_api.py - needed for naming convention/importability
  6. Introduce tests for inference_api.py

This PR requires bumping up images and having Kaito use updated image tag (in this case 0.0.2).

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f50583) 65.27% compared to head (db7e010) 65.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   65.27%   65.27%           
=======================================
  Files          14       14           
  Lines        1123     1123           
=======================================
  Hits          733      733           
  Misses        352      352           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fei-Guo Fei-Guo merged commit 68c972d into main Feb 21, 2024
21 checks passed
@Fei-Guo Fei-Guo deleted the Ishaan/clean-api branch February 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants