Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Commenting and Renaming #194

Merged
merged 14 commits into from
Jan 4, 2024
Merged

chore: Commenting and Renaming #194

merged 14 commits into from
Jan 4, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Dec 19, 2023

rename modelname -> modelfamilyname
accessmode -> ImageAccessMode
Add comments to interface.go and preset-inferences.go

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bdcac7a) 68.66% compared to head (114ff7a) 68.66%.

Files Patch % Lines
pkg/controllers/workspace_controller.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files          14       14           
  Lines        1366     1366           
=======================================
  Hits          938      938           
  Misses        391      391           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 changed the title chore: Add comment on run params chore: Commenting and Renaming Dec 20, 2023
@Fei-Guo Fei-Guo merged commit e0dd658 into main Jan 4, 2024
8 checks passed
@Fei-Guo Fei-Guo deleted the Ishaan/cmd-line branch January 4, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants