Update keystore examples #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nohkwak
commented
Jun 28, 2024
nohkwak
commented
- Update keystore example in ethers-ext
- Add keystore example in web3js-ext
kjeom
reviewed
Jul 1, 2024
| console.log("\ndecrypted privateKey"); | ||
| console.log(account[0].privateKey); | ||
|
|
||
| web3.eth.accounts.wallet.encrypt(password2).then((encryptedKey2) => { |
There was a problem hiding this comment.
@nohkwak Please match ethers and web3js examples.
The encrypt and decrypt code pattern looks different
There was a problem hiding this comment.
@kjeom
The built-in functions of ethers and web3 are different, so let’s talk about it at tomorrow’s meeting.
There was a problem hiding this comment.
@nohkwak
ethers-ext: encrypt - decrypt.then(encrypt)
web3js-ext: encrypt - decrypt - encrypt
I mean the pattern needs to be matched.
There was a problem hiding this comment.
current: encrypted - decrypt - encrypt - decrypt
There was a problem hiding this comment.
@kjeom
I updated examples by removing the callback functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.