Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update rpc docs #48

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Feat/update rpc docs #48

merged 6 commits into from
Oct 10, 2024

Conversation

Sotatek-TanHoang
Copy link
Contributor

refer to issue: #45

  • update eth_estimateGas and kaia_estimateGas (params stateOverrideSet is currently not included due to web3j issue)
  • update getParams, getChainConfig description in kaia, governance namespace
  • update governance vote params and rpc description
  • add missing APIs in klay_ namespace (api getParams and getChainConfig is existed in klay, update description follow kaia)

kaia,klay,governance _getChainConfig,_getParams
eth, klay, kaia estimateGas
governance _vote
@Sotatek-TanHoang
Copy link
Contributor Author

Sotatek-TanHoang commented Oct 8, 2024

Currently estimateGas params StateOverrideSet is not generated correctly in web3j. It is skipped in this PR.

@Sotatek-TanHoang Sotatek-TanHoang changed the title [WIP]Feat/update rpc docs Feat/update rpc docs Oct 8, 2024
@kjeom
Copy link
Member

kjeom commented Oct 9, 2024

Currently estimateGas params StateOverrideSet is not generated correctly in web3j. It is skipped in this PR.

  • web3rpc-java is currently applying "Object" parameter pattern because the code generator cannot generate all kind of parameter types correctly. In this case, it's very tricky to make the optional parameters. We are using the "overloading" pattern to do this.

  • estimateGas needs two optional parameters in this PR. It is hard to resolve because of the limitation of the java. But no issue except web3rpc-java

@Sotatek-TanHoang Sotatek-TanHoang merged commit 9552ab7 into dev Oct 10, 2024
2 checks passed
@Sotatek-TanHoang Sotatek-TanHoang deleted the feat/update-rpc-docs branch October 10, 2024 04:21
@Sotatek-TanHoang Sotatek-TanHoang restored the feat/update-rpc-docs branch October 10, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants