Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3modal update #192

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

youngancient
Copy link
Contributor

Proposed changes

  • Updated klaytn to kairos in verify-deployment docs
  • Updated web3modal to appkit
  • Updated walletconnect to reown
  • Fixed broken banner image

Types of changes

Please put an x in the boxes related to your change.

  • Minor Issues and Typos
  • Major Content Contribution
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to reach out. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@youngancient
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@@ -49,7 +49,7 @@ module.exports = {
},
etherscan: {
apiKey: {
klaytn: "unnecessary",
kairos: "unnecessary",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youngancient Thanks for your contribution.
Did you test it with explorer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did. My first step was to deploy a contract on kaia testnet (kairos) and then verify.
My hardhat config at first looked like this:

import { HardhatUserConfig } from "hardhat/config";
import "@nomicfoundation/hardhat-toolbox";

require('dotenv').config();

const config: HardhatUserConfig = {
  solidity: "0.8.20",
  networks: {
    // for testnet
    kairos: {
      url: process.env.VITE_KAIA_TESTNET_RPC_URL!,
      accounts: [process.env.PRIVATE_KEY!],
      // gasPrice: 100000000000,
    },
  },
  etherscan: {
    apiKey: {
      klaytn: "unnecessary",
    },
    customChains: [
      {
        network: "kairos",
        chainId: 1001,
        urls: {
          apiURL: "https://api-baobab.klaytnscope.com/api",
          browserURL: "https://kairos.kaiascope.com",
        },
      },
    ],
  },
};

export default config;

In the network object, the network name is "kairos" but in the etherscan apiKey obj, "klaytn" was there, so I had the bug which was fixed by changing klaytn to kairos.

The verified contract

@scott-klaytn scott-klaytn merged commit c3ba742 into kaiachain:main Dec 23, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants