fix(service)!: support unlimited ulimits #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `soft` and `hard` fields of `compose_spec::service::Ulimit` to `compose_spec::service::Limit<u64>`. Changed `compose_spec::service::Ulimits` type alias (used for `ulimits` field of `compose_spec::Service` and `compose_spec::service::Build`) to `IndexMap<Resource, ShortOrLong<Limit<u64>, Ulimit>>`. Changed `<Ulimit as AsShort>::Short` to `Limit<u64>`. Added `impl From<Limit<u64>> for Ulimit`. Added `impl From<u64> for Limit<u64>`. Added `impl<T, L> From<Limit<T>> for ShortOrLong<Limit<T>, L>` and `impl<L> From<u64> for ShortOrLong<Limit<u64>, L>`. Fixes: #31
k9withabone
force-pushed
the
service-ulimits-unlimited
branch
from
b12bfbd to
622ba03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
softandhardfields ofcompose_spec::service::Ulimittocompose_spec::service::Limit<u64>.Changed
compose_spec::service::Ulimitstype alias (used forulimitsfield ofcompose_spec::Serviceandcompose_spec::service::Build) toIndexMap<Resource, ShortOrLong<Limit<u64>, Ulimit>>.Changed
<Ulimit as AsShort>::ShorttoLimit<u64>.Added
impl From<Limit<u64>> for Ulimit.Added
impl From<u64> for Limit<u64>.Added
impl<T, L> From<Limit<T>> for ShortOrLong<Limit<T>, L>andimpl<L> From<u64> for ShortOrLong<Limit<u64>, L>.Fixes: #31