[WIP] build nw status with every container interfaces #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is to update nw status with all relevant information when pod container has secondary interface with its vlan sub interfaces. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
|
/cc @JanScheurich, @phoracek |
|
This looks good -- any chance you would mind adding a unit test to check for this status? Thanks! (edit to add: also realize you've marked this a WIP, sorry for premature ask, too) |
e0ne
reviewed
May 28, 2021
| if err != nil { | ||
| return nil, cmdErr(k8sArgs, "error setting network status: %v", err) | ||
| } | ||
|
|
||
| netStatus = append(netStatus, *delegateNetStatus) | ||
| for _, delegateNetStatus := range delegateNetStatuses { |
There was a problem hiding this comment.
Can we just change it to:
netStatus = append(netStatus, delegateNetStatuses...)
and omit loop?
|
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is to update nw status with all relevant information
when pod container has secondary interface with its vlan sub
interfaces.
Here is a multi interface use case described in this ovs-cni PR
This PR depends on API changes in network-attachment-definition-client PR
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech